fix: Handle Data With Invalid User #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Kuchenpirat
reviewed
Oct 14, 2024
Co-authored-by: Kuchenpirat <[email protected]>
Co-authored-by: Kuchenpirat <[email protected]>
Kuchenpirat
approved these changes
Oct 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Currently there are several issues related to how we handle deleting users:
This PR aims to partially solve this since it causes breaking issues with households (see #4294). This PR adds a new db fix which finds all rows with invalid users and replaces them with a valid user. The valid user is arbitrary, though we attempt to find an admin in the group.
Which issue(s) this PR fixes:
(REQUIRED)
Somewhat addresses #3171, but we can do better so we shouldn't close it
Fixes #3219 (while we don't address invalid group ids in this PR, it's not super necessary since those are isolated instances anyway)
Fixes #4294
Testing
(fill-in or delete this section)
Tested locally