fix: Strip Timezone from Timestamps in DB #4310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR explicitly removes time zones from
datetime
objects before storing them in the database, then re-adds the UTC timezone when retrieving them.We do this because when using naive datetimes with postgres (which is what Mealie uses), postgres will convert datetimes to local time when storing. So, for instance, if we send this dt to postgres:
And the postgres db timezone is in America/Chicago, it will store the dt as:
Note that the time is not UTC, and the timezone info is now removed. So, once we retrieve it, we assume
2024-10-03T08:34:32
is UTC, and our timestamps are off.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4288
Special notes for your reviewer:
Pretty simple fix, super annoying to debug.
Testing
(fill-in or delete this section)
I set my dev postgres db to
Europe/Bratislava
and Mealie asUTC
and observed the issue in #4288. After this fix I no longer had any issues, and I manually verified the timestamps were correct (I also checked on SQLite just to make sure).