fix: Hide rating on notes #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have more time to deal with the merge conflict later tonight. |
|
IIRC the component handles whether or not you can set a rating, which is why it's not hidden from users from other groups (so they can still see the rating, just not set it) |
michael-genson
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
I saw that note only "recipes" only the meal planner were allowing me to give a rating.. which resulted in a 400 or 404 (can't remember).
This stops the rating from appearing (making it similar to favourite which was already hidden).
Before:
After:
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
The favourites badge a couple lines above this code has a limitation of
isOwnGroup, whereas rating doesn't. I believe that was intentional from Michael when initially implementing per-user ratings.Testing
The screenshots basically. Confirmed no impact against a real recipe.