fix: Exclude additional sensitive information from mealie logs #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OIDC_CLIENT_ID is not sensitive |
boc-the-git
requested changes
Sep 18, 2024
Co-authored-by: boc-the-git <[email protected]>
boc-the-git
approved these changes
Sep 21, 2024
…tion-in-log-files
boc-the-git
added a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
…e-recipes#4218) Co-authored-by: boc-the-git <[email protected]>
boc-the-git
added a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
…e-recipes#4218) Co-authored-by: boc-the-git <[email protected]>
Choromanski
pushed a commit
to Choromanski/mealie
that referenced
this pull request
Oct 1, 2024
…e-recipes#4218) Co-authored-by: boc-the-git <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Add LDAP_QUERY_PASSWORD, OIDC_CLIENT_ID, and OPENAI_API_KEY to the list of excluded settings when logging.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #4217
Testing
Run Mealie and view the logs, you should no longer see the above listed variables printed to the log on startup.