feat: Reorder ShoppingListItemEditor #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
changed the title
michael-genson
approved these changes
Sep 12, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Choromanski
pushed a commit
to Choromanski/mealie
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The ShoppingListItemEditor field order does not make much sense from an input sense (Especially for the Food input)
The current order to add a food is: Food ➡️ Unit ➡️ Note ➡️ Quantity
I reordered it to use a more logical input order of: Quantity ➡️ Unit ➡️ Food ➡️ Note, while also keeping Quantity, Unit and Food in one row.
This has the added benefit that it is way easier to read the edit field is now matching the displayed order of the shopping list making edits of existing field more intuitive.
The current order to add a Note is: Note ➡️ Quantity which i changed arround to have it match the shoping list item.
Screenshots
Which issue(s) this PR fixes:
None
Testing
Manual testing, i pretty much just reordered things so it should be fine.