feat: Seed support for plural units #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
approved these changes
Aug 20, 2024
|
@michael-genson I would like to also do the same with food seeder but that would require restructuring the local files and I'm unsure if that would cause problems with crowdin. |
|
@Choromanski Hey sorry, meant to get back to you on this. In theory as long as they keys are the same, the translations should copy over. We should be able to fix it manually if not |
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Co-authored-by: Hayden <[email protected]>
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
Sep 28, 2024
Co-authored-by: Hayden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR allows the seeder to import plural names and plural abbreviation for units.
This allows for new user have cleaner ingredient lists without having to do any configuration.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
In commit 21216a6 I made some changes I'd be happy to revert:
I modified one of the crowdin files, not sure if there is anything additional I need to do.
I would like to also do the same with food seeder but that would require restructuring the local files and I'm unsure if that would cause problems with crowdin.
Testing
Ran a fresh install and all of the unit data was seeded properly: