fix: prevent postgres credentials leak #3895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
I received a security report that in some cases the API could return the password of the Postgres database. This only showed up when the user was an administrator. I modified the logic of the public URL to not use replace logic and just construct a dummer representation of the db url. Additionally, if they are deploying with a custom Postgres URL we just return a place holder value. I think this is the best approach instead of trying to parse out the username and password.
Which issue(s) this PR fixes:
Internal security report
Special notes for your reviewer:
Testing