-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Data Management from Shopping List #3603
feat: Data Management from Shopping List #3603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few linter issues on this one @michael-genson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm effectively happy to approve this, bar the linting issues previously mentioned and ..
The "Copy to Food" functionality. I like it, but I wonder it it's going to not be clear to a user what it's actually doing? Particularly for say the 2nd and 3rd user of a system, not the "power user".. Thoughts? Wondering if there's an alternate wording, maybe something like "Permanently add Label to Food" (..but not exactly that)
Yeah I couldn't come up with anything concise enough other than "Copy to Food". Some others:
I was avoiding "permanently" because it seems like a bulky word here, but that could work too. Also maybe adding a tooltip can work? |
I would suggest going for something shorter like I think you kinda don't need to reference Food since this is the toggled option. But a tooltip might be a nice middleground, but are not that practical on mobile. |
Maybe "Set Label" or "Apply Label"? Or "Save Label"? I agree with dropping Food. It's more than "Add" because a Food might already have a Label, just a different one. |
Co-authored-by: boc-the-git <[email protected]>
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR enables managing data from a shopping list. Namely:
This also fixes a visual bug when creating new foods/units on recipes by force-closing the dropdown.
Creating foods from the shopping list (with fixed visual bug):
Assigning label to food (note that other instances of "apple" are not updated because those items are already set to produce):
(not pictured: the food "apple" is now re-labeled as "Juice")
Which issue(s) this PR fixes:
(REQUIRED)
Closes #3602
Testing
(fill-in or delete this section)
Manually