fix: MultiPurposeLabel text color #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
changed the title
Kuchenpirat
changed the title
michael-genson
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
To determine the text Color of the MultiPurposeLabel Chip we expexted a 6 digit hex RGB-value.
If it was less than 4 the label was always white and since vuetify (which handles the Labels background color) does support multiple color spaces it was possible to end up with e.g a white label with white text.
This uses the already installed @sphinxxxx/color-conversion to support multiple color spaces. Additionaly i added an condition that always returns black text when the opacity of the background color is less than 30%.
This theoretically also alows for color to be written out. E.g writing "purple" in the color field.
Which issue(s) this PR fixes:
Fixes #3433
Special notes for your reviewer:
None
Testing
manual