-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate ld+json data #3444
fix: duplicate ld+json data #3444
Conversation
|
Fixed my local prod and confirmed it still works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Fixes the duplicate
ld+json
data causing scrapers to grab the wrong recipes. I used two different solutions:Due to how our metadata injection works, technically the recipe's data follows you around (for example, if you open a recipe for chocolate brownies, then head to the home page, the chocolate brownie metadata is still present) however I tested this and it's always correct when navigating to any page directly (which is all that matters for scrapers).
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3068
Fixes #3374
Testing
(fill-in or delete this section)
Built a production instance locally and verified that exactly one instance of recipe metadata is present, and it's the correct recipe.