fix: Repeated calls to group self #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
As shown in issue #3317, PR #3303 introduced a bug where each recipe makes a call to
.../groups/self. This is especially apparent on the home page (as there are typically dozens of recipes that load immediately, all of which make the API call).This PR implements a shared state similar to the one introduced in #3306. I also noticed that the group self call returns a ton of data which could be considered private (all user data is in the response body), not to mention simply unnecessary, so similar to #3305 I created a
GroupSummarymodel that only returns basic info (id,name,slug, and preferences).Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3317
Testing
(fill-in or delete this section)
Manually verified the self route is only called once per page, and manually verified none of the "unnecessary" data was being used.