fix: Allow UserOut to accept list of slugs for recipe favorites #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
force-pushed
the
fix/recipe-favorite-slug-handling
branch
from
1ecaa9f to
48fb200
Compare
michael-genson
force-pushed
the
fix/recipe-favorite-slug-handling
branch
from
48fb200 to
21d5773
Compare
|
LGTM 🚀 |
boc-the-git
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
#3134 adapted previous Pydantic V1 behavior with getter dicts by converting recipes to their slugs using a validator. However, sometimes a list of slugs is passed directly, which doesn't work anymore. This fixes that.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3282
Testing
(fill-in or delete this section)
Manually added/removed recipe favorites and updated other unrelated user settings (as shown in #3282)