dev: add docker-in-docker to dev container #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
requested changes
Feb 9, 2024
|
Have removed the comments. |
boc-the-git
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds the ability to run docker commands from within the dev container console.
This is needed to run
task docker:prodto create a production image andtask dev:servicesto run a postgres db and mailpitUses the feature described here: https://github.com/devcontainers/features/tree/main/src/docker-in-docker
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Rebuild of the dev container needed.
Docker-outside-of-Docker would be also be an option which runs the container directly on the host.
Testing
build a local prod image and started the services.
Only tested on a Windows (win 11) machine.