Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: On new release publish, update image tags in sample docker-compose files #3072

Conversation

boc-the-git
Copy link
Collaborator

What type of PR is this?

  • documentation
  • feature

What this PR does / why we need it:

Modifies the release workflow to also update our documentation when a new release is published.

Which issue(s) this PR fixes:

None.

Testing

Via my fork, I created this release, which triggered this workflow (note that it's not the exact one I'm merging here, it's a modified version for testing purposes), which resulted in this commit.

The github workflow used for testing is screenshot, as I'll likely delete it before too long:
image

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make this so much easier to keep the docs updated :)

Just to get what is going on here:
This will update the files after the build release has finished. Will this then also trigger another nightly action?
(which propably is fine, as those run pretty fast for doc changes)

@boc-the-git
Copy link
Collaborator Author

This will make this so much easier to keep the docs updated :)

🥳 🎉

This will update the files after the build release has finished.

Yes 👍

Will this then also trigger another nightly action? (which propably is fine, as those run pretty fast for doc changes)

No.
It didn't happen on my test and I was curious why (after your question). My belief is it's because we're committing directly against the mealie-next branch and not pushing to it. This is the documentation for push, which we're using here to trigger the nightly.

I think not building a new nightly is the most logical answer, because this is a change that doesn't impact the application in any way; it only changes the documentation site, which reads directly from the repo.

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound all good to me :)
This will certainly come handy in future releases 😊

@Kuchenpirat Kuchenpirat enabled auto-merge (squash) January 30, 2024 07:31
@Kuchenpirat Kuchenpirat merged commit 7e51cf0 into mealie-recipes:mealie-next Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants