-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updating "Label" Seed file to align with future seed logic changes #3037
Conversation
updating food labels to new format, need to look at seed logic to complete mealie-recipes#1230. New JSON seed file in english https://paste.catduck.net/view/iCWk7fo
|
Thanks, for now I think simply updating the current seed files are the way to go. I plan to go through and add some color logic. My thoughts are to merge that, let things get translated (for everyone) before changing seed logic? |
My initial feedback is that I'm not sure that this is the right format when we consider translations {
"label": "Supplements & Extracts",
"aliases": [],
"description": "",
"name": "lemon extract",
"pluralName": "lemon extracts"
} Each entry is going to have to be translated so the labels will have the be translated multiple times in the translation UI. Would reworking the structure into a nested field work better?
Then we can manage all the seeds and stuff in one place. This also might make it easier to do seeding by language.
I don't think this is really possible. we don't want to ship anything half implemented, and we always want everything in the |
@hay-kot I did it the way I did, because that matched how things looked both currently, and how an export looked. |
Hey, do you plan on continuing to work on this? |
I want too, some things came up. I'm concerned about my ability to do the bigger changes required, not having as much experience. Let me try to dive into again within the next few weeks |
I'll go ahead an close this PR for now. Feel free to reopen if you come back to this. |
Revisiting this... @hay-kot is this the format you were thinking? I took the foods generated by @catduckgnaf and moved to the format (I think), you suggested. If people are in alignment with using this format, I can take a crack at the necessary changes needed to seeders.py to parse the new file. Using this format, I believe both the labels and the food seeds could be parsed from the same file at the same time. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Testing
Validated JSON