-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Foreign Key Violations During Backup Restore #2986
Merged
michael-genson
merged 14 commits into
mealie-recipes:mealie-next
from
michael-genson:fix/foreign-key-violations-during-migration
Jan 16, 2024
Merged
fix: Foreign Key Violations During Backup Restore #2986
michael-genson
merged 14 commits into
mealie-recipes:mealie-next
from
michael-genson:fix/foreign-key-violations-during-migration
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I manually confirmed the data locally looks correct. The number of recipes matches, the number of users matches, and the expected invalid foreign keys are missing. |
6 tasks
hay-kot
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much more simple than what I tried to do 10/10
hay-kot
approved these changes
Jan 16, 2024
michael-genson
deleted the
fix/foreign-key-violations-during-migration
branch
January 16, 2024 22:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR removes objects with invalid foreign keys when doing a database restore. Prior to this PR, any databases containing objects with invalid foreign keys will fail to restore on postgres due to foreign key checks.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2499
Fixes #2985