-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove OCR Support #2838
feat: Remove OCR Support #2838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe run make docs
to remove the ocr endpoints from the api references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
Will not merge yet, as maybe somebody with more experience should have another go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LET'S GOOOOOOOOOO
I know we have our differences and as the person that wrote this feature and lost interest in maintaining it due to multiple factors, I agree fully with this decision from your point of view and I respect it. I'll continue to use mealie as long as it is the better open source recipe manager which I think that it still is. |
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This removes OCR from Mealie. This is done for a few reasons:
Which issue(s) this PR fixes:
(REQUIRED)
Closes #2394
Closes #2424
Closes #2437
Closes #2451
Special notes for your reviewer:
(fill-in or delete this section)
I removed the
is_ocr_recipe
field from the schema, but left it in the db (since we can't easily remove it from sqlite). I also left all of the translations and the mdi-icons, in case we're able to re-purpose them. Happy to remove those if needed.