cleanup: remove group storage capacity from profile page #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
changed the title
hay-kot
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR removes the field that displays the used group storage from the
/user/profile/page.This field does not have much purpose, as the limit set is arbitrary and not enforced which is confusing to users and also not necessairy as mealie can handle larger than 500mb recipe librarys quite well.
Instead of the storage capacity field i stretched the field for group statistics along the whole width.
Screenshots:
Which issue(s) this PR fixes:
This does not fix any issues in particular, but the removal was discussed in discord multiple times.
Special notes for your reviewer:
I left the backend functionality in the code for now, as i think it might be interesting to some admins to know how much space a particular group uses.
Aditionally we could reuse that functionality on the
/admin/manage/groupspage.I am not really satisfied with the new look, we might think of something else to put there or justify the block in the middle / the icons to the left.
Testing
manual testing