Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frontend improvements #2754

Merged

Conversation

p0lycarpio
Copy link
Contributor

@p0lycarpio p0lycarpio commented Nov 24, 2023

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • feature

What this PR does / why we need it:

(REQUIRED)

This PR aims to improve severals components/pages :

  • fixing spacing for display on small screens on recipe page
  • enable Markdown on recipe timeline events & recipe comments
  • backup page : add restore button & implement loader during process. add toast notification when restore is completed

Spacing & margins

Before/After


Markdown on comments & timeline

Before
Capture d’écran du 2023-11-25 14-00-18

After
Capture d’écran du 2023-11-25 13-54-35


Before
Capture d’écran du 2023-11-25 14-03-51

After
Capture d’écran du 2023-11-25 13-54-53

Backup/restore page

Before
Capture d’écran du 2023-11-25 14-04-36

After
Capture d’écran du 2023-11-25 13-56-33


Before/After

Which issue(s) this PR fixes:

(REQUIRED)

N/A

@boc-the-git
Copy link
Collaborator

With these being mostly (entirely?) visual changes, are you able to include before/after screenshots in the PR description to show the changes please @p0lycarpio?

@p0lycarpio
Copy link
Contributor Author

Sure @boc-the-git

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks for adding the images @p0lycarpio

@boc-the-git boc-the-git merged commit 340841b into mealie-recipes:mealie-next Nov 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants