Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manage data - Improve delete prompt #2746

Conversation

Kuchenpirat
Copy link
Collaborator

What type of PR is this?

  • (mini) feature

What this PR does / why we need it:

Shows which item will get deleted in the Confirmation Prompt.

image

Which issue(s) this PR fixes:

None

Testing

Did some manual testing. As this does not touch any of the actual functionality it should not break anything

@Kuchenpirat
Copy link
Collaborator Author

Kuchenpirat commented Nov 21, 2023

Have another version with the icon of the item in the front, but that might be a bit too playful.

image

@Kuchenpirat Kuchenpirat changed the title Manage data - Improve delete prompt feat: Manage data - Improve delete prompt Nov 22, 2023
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice QOL improvement

@boc-the-git boc-the-git merged commit 2ff0b60 into mealie-recipes:mealie-next Nov 24, 2023
6 checks passed
@Kuchenpirat Kuchenpirat deleted the manage-data-improve-delete-prompt branch November 24, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants