Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude DB_PROVIDER from logging #2625

Merged

Conversation

boc-the-git
Copy link
Collaborator

@boc-the-git boc-the-git commented Oct 12, 2023

What type of PR is this?

  • bug

What this PR does / why we need it:

  • Avoid outputting sensitive database information in logs

Which issue(s) this PR fixes:

Fixes #2604

Testing

Using the included docker-compose file (modified to include/use postgres) I confirmed the issue existed, made the change, and confirm it no longer exists.

Release Notes

NONE

@boc-the-git
Copy link
Collaborator Author

Before:
image

After:
image

@hay-kot hay-kot enabled auto-merge (squash) October 13, 2023 16:28
@hay-kot hay-kot merged commit 5bc78f8 into mealie-recipes:mealie-next Oct 13, 2023
@boc-the-git boc-the-git deleted the Exclude-DB-Credentials-From-Log branch October 13, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL password is shown in plaintext in logging
2 participants