Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change Logic for disableAmount in Shopping List Items #2518

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

With the new changes in #2502, if a shopping list item is added to your shopping list and contains a food with zero quantity, disableAmount is flagged and the item comes across blank:
image
image

This PR updates the logic for this edgecase:
image

Which issue(s) this PR fixes:

(REQUIRED)

N/A

Testing

(fill-in or delete this section)

I tested these scenarios (just to be thorough) and they behave as expected:

  • item with food, note, and 0 qty
  • item with food, note, and 1 qty
  • item with food, note, and 2 qty
  • item with food, no note, and 0 qty
  • item with food, no note, and 1 qty
  • item with food, no note, and 2 qty
  • item with no food, note, and 0 qty
  • item with no food, note, and 1 qty
  • item with no food, note, and 2 qty

Release Notes

(REQUIRED)

fixed shopping list item display issue when a food with no quantity is added

@michael-genson
Copy link
Collaborator Author

Since this was an issue with the template, not the composable, there wasn't a test to update

@hay-kot hay-kot merged commit 5213a61 into mealie-recipes:mealie-next Aug 22, 2023
@michael-genson michael-genson deleted the fix/shopping-list-item-display-zero-quantity branch August 22, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants