fix performance issues on /api/foods #2163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As mentioned in discord, the /api/foods endpoint can be pretty slow if you have a larger number of foods and especially if you use the extras feature for foods. I identified two causes for this:
**GetterDict(name_orm)
would cause pydantic to try and resolve ALL model relationships, even if they are not used in the response, causing even more lazy-loadingTo improve on this, I added a query_options function to RepositoryGeneric, so every sub-repository can specify its own loading options, if needed. Additionally I rewrote the getter_dict override so it just does the thing it is supposed to do and not cause any more unnecessary loading
Which issue(s) this PR fixes:
No issue filed
Testing
Ran all the tests and tried everything manually
Release Notes