Feature: Shopping List Item Pagination Route #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleshgolem
reviewed
Feb 18, 2023
| @@ -177,6 +177,10 @@ class ShoppingListItemsCollectionOut(MealieModel): | |||
| deleted_items: list[ShoppingListItemOut] = [] | |||
|
|
|||
|
|
|||
| class ShoppingListItemPagination(PaginationBase): | |||
There was a problem hiding this comment.
There really is no need for this, since PaginationBase is generic to begin with and this subclass doesnt add anything in particular. You can just use PaginationBase[ShoppingListItemOut] instead
There was a problem hiding this comment.
Yeah the only reason I added it is because we have them for all other get_all routes, so I wanted to keep it consistent with the rest of the code base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adds a pagination route for shopping list items. This is particularly useful to query for only unchecked items, i.e.
checked=false(which is generally what you want in an external app).Which issue(s) this PR fixes:
(REQUIRED)
N/A
Testing
(fill-in or delete this section)
Pytest
Release Notes
(REQUIRED)