Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml #2109

Merged
merged 5 commits into from
Feb 12, 2023
Merged

Conversation

rocket357
Copy link
Contributor

ERROR: The Compose file './docker-compose.yml' is invalid because: services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null

What type of PR is this?

  • bug

What this PR does / why we need it:

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null

Which issue(s) this PR fixes:

N/A - Should I open an issue first, or is jumping straight to PR sufficient?

Special notes for your reviewer:

None, simple fix.

Testing

docker01:~# docker version
Client:
 Version:           20.10.16
 API version:       1.41
 Go version:        go1.18.2
 Git commit:        aa7e414fdcb23a66e8fabbef0a560ef1769eace5
 Built:             Sun May 15 14:51:52 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.16
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.18.2
  Git commit:       f756502055d2e36a84f2068e6620bea5ecf09058
  Built:            Sun May 15 14:46:21 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.6.6
  GitCommit:        10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
 runc:
  Version:          1.1.2
  GitCommit:        a916309fff0f838eb94e928713dbc3c0d0ac7aa4
 docker-init:
  Version:          0.19.0
  GitCommit:

Release Notes

N/A

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null
Also fix SMTP settings, since they aren't in array format as in mealie-frontend.
@rocket357
Copy link
Contributor Author

rocket357 commented Feb 9, 2023

Updated the PR to fix a few issues I ran into on enabling SMTP as well. If I need to split anything off (since it was a basic bugfix to begin with), please let me know! =)

Server status reported this, I think this is the correct value, but I'm happy to revert and/or update the value as needed.
Copy link
Collaborator

@hay-kot hay-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the rest of the changes, or let me know why we need to make these changes if it's no intended for end users?

@@ -65,20 +66,20 @@ services:

# =====================================
# Web Concurrency
WEB_GUNICORN: true
WEB_GUNICORN: "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I think is warranted.

This docker-compose file is meant for end users so the annotations aren't super useful. For end-users you should be using the documentation. This also doesn't seem to be a problem on newer versions of docker-compose? 🤷

Configuration is also documented

@rocket357
Copy link
Contributor Author

Yep, I got a little over-zealous making changes =)

I'll revert the other two commits. Thanks!

Missed a stray newline that was inadvertently added.
@hay-kot hay-kot merged commit fc105dc into mealie-recipes:mealie-next Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants