-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose.yml #2109
Conversation
ERROR: The Compose file './docker-compose.yml' is invalid because: services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null
Also fix SMTP settings, since they aren't in array format as in mealie-frontend.
Updated the PR to fix a few issues I ran into on enabling SMTP as well. If I need to split anything off (since it was a basic bugfix to begin with), please let me know! =) |
Server status reported this, I think this is the correct value, but I'm happy to revert and/or update the value as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the rest of the changes, or let me know why we need to make these changes if it's no intended for end users?
@@ -65,20 +66,20 @@ services: | |||
|
|||
# ===================================== | |||
# Web Concurrency | |||
WEB_GUNICORN: true | |||
WEB_GUNICORN: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change I think is warranted.
This docker-compose file is meant for end users so the annotations aren't super useful. For end-users you should be using the documentation. This also doesn't seem to be a problem on newer versions of docker-compose? 🤷
Configuration is also documented
Yep, I got a little over-zealous making changes =) I'll revert the other two commits. Thanks! |
Missed a stray newline that was inadvertently added.
ERROR: The Compose file './docker-compose.yml' is invalid because: services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null
What type of PR is this?
What this PR does / why we need it:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.mealie.environment.WEB_GUNICORN contains true, which is an invalid type, it should be a string, number, or a null
Which issue(s) this PR fixes:
N/A - Should I open an issue first, or is jumping straight to PR sufficient?
Special notes for your reviewer:
None, simple fix.
Testing
Release Notes
N/A