Fix duplicate network calls on index page #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The index page (Recent Recipes) would always load the recipes itself and then the contained RecipeCardSection would also trigger another recipe load (which just gets ignored). That second one is of course just wasteful, but the hook is needed for all other pages, so I added a prop to just skip it in this particular case
I also modified the initial recipe loads, so that the foods only get loaded on search pages, since they are not needed anywhere else and having them added takes considerably longer
Which issue(s) this PR fixes:
Issue #2063
Testing
Ran tests, looked at all the different recipe pages
Release Notes