Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example postgres docker-compose setup in docs #1998

Merged

Conversation

fleshgolem
Copy link
Contributor

Add a local volume to postgres container so changes get persisted between restarts

What type of PR is this?

  • documentation

What this PR does / why we need it:

As it turned out on the discord yesterday, the example docker-compose.yml for a postgres setup is actually fairly misleading which can easily lead to frustrations: The postgres container does not get any volume attached, so it will never persist any data between restarts.

This quick change should alleviate that issue for inexperienced users (even though they probably shouldnt use postgres to begin with)

Which issue(s) this PR fixes:

AFAIK no issue has been filed for this

Release Notes

* Improved sample postgres setup in installation docs

Add a local volume to postgres container so changes get persisted between restarts
@hay-kot
Copy link
Collaborator

hay-kot commented Jan 7, 2023

The postgres container does not get any volume attached, so it will never persist any data between restarts.

Postgres uses named volumes defined in the Dockerfile so the data should be persistent by default without an explicit declaration. Though I think this is a good addition since explicit is better than relying implicit behavior.

Thanks for the PR!

@hay-kot hay-kot merged commit 5e97c32 into mealie-recipes:mealie-next Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants