Fix example postgres docker-compose setup in docs #1998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a local volume to postgres container so changes get persisted between restarts
What type of PR is this?
What this PR does / why we need it:
As it turned out on the discord yesterday, the example docker-compose.yml for a postgres setup is actually fairly misleading which can easily lead to frustrations: The postgres container does not get any volume attached, so it will never persist any data between restarts.
This quick change should alleviate that issue for inexperienced users (even though they probably shouldnt use postgres to begin with)
Which issue(s) this PR fixes:
AFAIK no issue has been filed for this
Release Notes