Fix Issue#1317 #1848
Merged
Fix Issue#1317 #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdlam91
reviewed
Nov 22, 2022
| text | ||
| outlined | ||
| color="deep-orange" | ||
| >⚠️ Please note that you are trying to delete your own admin account! |
There was a problem hiding this comment.
Should put this inside a language file so it's more easily translatable
There was a problem hiding this comment.
Thanks for the feedback! I put the text inside the language file.
5 tasks
|
Looks great thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently, one can delete their own admin account without getting any warning text and lock themselves out from the system. This PR aims to solve this problem by providing the user with some warning text if they try to delete their own account, and this feature will prevent the user from accidentally deleting their own account.
Screenshot Example:
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1317
Special notes for your reviewer:
Testing
I manually tested this feature on Chrome and Mozilla browsers.
Release Notes
(REQUIRED)