Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - translation has no effect at import for number of servings #4046

Closed
6 tasks done
cameo77 opened this issue Aug 17, 2024 · 2 comments
Closed
6 tasks done

[BUG] - translation has no effect at import for number of servings #4046

cameo77 opened this issue Aug 17, 2024 · 2 comments
Labels
bug Something isn't working stale triage

Comments

@cameo77
Copy link

cameo77 commented Aug 17, 2024

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

I use my Mealie UI in German language and I usually import German recipes. At a recipe import from a website, Mealie imports also the number of servings. In the field, where this number is placed in, there is automatically added a "unit". So if I would use an English UI, the text field should contain, e.g. "6 servings". But in German, there should be written "6 Portionen" (in this example). But although my Mealie UI and the recipe is in German, there is still written "6 servings". Here you can see a screenshot:
image
The yellow marked "servings" should be named "Portionen".
I had a similiar issue with the cooking time units, but I was able to fix this with Crowdin. But in this case, there is no translation error in Crowdin. It seems to be an error in Mealie, because if I use the recipe import debugger, only the number can be found in the json, so looks like Mealie adds this "unit" automatically. Maybe this "servings" word is hard coded and not related to the translation files.

Steps to Reproduce

Just import a German recipe, in a German Mealie UI (maybe it's the same for other non-English languages).
For example, use this recipe.

Please provide relevant logs

--

Mealie Version

v1.11.0
Build: a41ad8c

Deployment

Docker (Linux)

Additional Deployment Details

No response

@cameo77 cameo77 added bug Something isn't working triage labels Aug 17, 2024
@mhoenes
Copy link

mhoenes commented Aug 19, 2024

This was already reported in #2807, but couldn't be fixed.

"servings" is added by the underlying scraper library automatically to the yield when a recipe doesn't specify a serving unit text.
It's done here in the recipe scraper code: https://github.com/hhursev/recipe-scrapers/blob/ad7377dcea6ffd1272f3fafbe3e396a3c55529cc/recipe_scrapers/_utils.py#L227

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale triage
Projects
None yet
Development

No branches or pull requests

2 participants