-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Bulk Import Failing RC2 #2788
Comments
Do you happen to have a list of recipes that failed? I pulled 16 random ones off of allrecipes.com and it works for me. |
confirm, this list is working!
|
Yup, can reproduce with your recipe list, it's causing a mess of errors haha. Looks like the issue is mostly that the bulk import isn't fault tolerant, so when it hits certain errors it just dies |
Thanks for confirming! |
To add additional samples, here is a list of URLs that will not import through the bulk import: http://www.eatwell101.com/honey-dijon-chicken-veggies-foil-packs From the logs, each one is returning HTTP status code of 301 |
I checked those, looks like eatwell101 doesn't properly expose their recipe data, so we can't scrape it. I did, however, run it through my PR and it behaves as expected (all recipes fail but the report doesn't fail) |
Honestly, that's good to know. This seems to be a different issue, the URLs are returning 301 status, if I load the URL in my browser, the new URL, and import that to Mealie, it works as expected (with the exception that the meal image isn't parsed.
Thank you for checking too.
Cheers,
Don
*Don Finley*
Founder | FINdustries ( https://fin.dustries.com/ )
***@***.***
M: 610.213.3477
Our Manifesto ( http://fin.dustries.com/manifesto/ )
…On Wed, Dec 06, 2023 at 5:44 PM, Michael Genson < ***@***.*** > wrote:
I checked those, looks like eatwell101 doesn't properly expose their
recipe data, so we can't scrape it.
I did, however, run it through my PR and it behaves as expected (all
recipes fail but the report doesn't fail)
—
Reply to this email directly, view it on GitHub (
#2788 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABJ55LE7UFAVG5RW7FSUKDLYIDYMFAVCNFSM6AAAAABAH4LZVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTHAYDQMBUGY
).
You are receiving this because you are subscribed to this thread. Message
ID: <mealie-recipes/mealie/issues/2788/1843808046 @ github. com>
|
The 301 is just saying it's been relocated, but you should see 200 requests following the 301's |
First Check
What is the issue you are experiencing?
Bulk import fails to import and doesn't throw an error.
Steps to Reproduce
1)Import url
2) Add bulk import
3) Add urls
4) Send
Please provide relevant logs
Mealie Version
Details
Versie: v1.0.0-RC2
Bouw: c9852da
Toepassingsmodus: Productie
Demostatus: Geen demo
API-poort: 10018
API-documentatie: Ingeschakeld
Databasetype: postgres
Versie van de receptenscraper: 14.52.0
Checks
Beveiligde website: Nee
Server-side basis-URL: Ja
LDAP klaar: Nee
E-mail geconfigureerd: Nee
Docker Volume: success
Deployment
Docker (Linux)
Additional Deployment Details
Truecharts Truenas scale
The text was updated successfully, but these errors were encountered: