Update CRF++ build for 2024 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run autoreconf when building to use the updated autotools * Clean up configure.ac to replace obsolete macros * Use multi-stage docker build for smaller final container
* Prevent compilation warnings for deprecated features in newer C++ dialects
Generated files should not be in source control. Instead they are included in source tarballs generated from source control by Make.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The aim of this PR is to update the build process of CRF++. The first step of this is to run
autoreconfwhen building the docker image so that a newerconfigurescript is used. This avoids having to explicitly set the build architecture for ARM64 builds, since the newerconfigurecan successfully detect the arch on its own.Next up I've removed the existing files generated by an old autotools version. They're obsolete, and not needed in the Git repo. I've added instructions to
README.mdon how to properly generate a source tarball, for people that want to go with the oldtar xzf && ./configure && make && make installapproach.Finally, I've also specified the C and C++ standards for GCC to target. This avoids compilation warnings about using the
registerkeyword. I chose standards to match what GCC 3.0 supports, which is specified in the original installation instructions.Please let me know if there's anything more to do before this can be merged.