Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parentheses in note title is not parsed #70

Closed
huangziwei opened this issue Feb 13, 2022 · 6 comments
Closed

Parentheses in note title is not parsed #70

huangziwei opened this issue Feb 13, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@huangziwei
Copy link

For example, a note with a title How to Take Smart Notes (2017) by Sönke Ahrens was referred in another note as [[How to Take Smart Notes (2017) by Sönke Ahrens]], but it is parsed as <span class="missing-link" style="color:darkred;">How to Take Smart Notes</span> in the HTML generated by mdzk.

@kmaasrud
Copy link
Member

First, I apologize for the really late reply!

This is weird, parentheses should be working. I'll try to reproduce your issue, make a test case for it and see if there is an issue in our link parsing.

In the meantime: We just released mdzk 0.5.1, which includes a lot of changes and fixes. Could you check against it and see if your problem persists?

@kmaasrud kmaasrud added the bug Something isn't working label Feb 21, 2022
@huangziwei
Copy link
Author

@kmaasrud just tried 0.5.1 and the problem persists.

@kmaasrud
Copy link
Member

Allright, thanks for checking 😄

We might not do a whole new release with a patch for this, as we are changing quite a lot with how mdzk works atm. However, I can see if I find the culprit and push the fixes, so that you can install from upstream! Will keep you posted

@huangziwei
Copy link
Author

No problem. I already adapted to the tool and now use "Author - YEAR - TITLE" as note title. :-)

@kmaasrud
Copy link
Member

This was apparently caused by a logical error in our parser grammar. By compiling from HEAD with a command like cargo install --git https://github.com/mdzk-rs/mdzk, links with parentheses or curly brackets should now work.

@kmaasrud
Copy link
Member

FYI, the fix is included in 0.5.2 which was just released!

kmaasrud added a commit that referenced this issue Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants