Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation Bug #3

Open
YoriKv opened this issue Oct 3, 2018 · 2 comments
Open

Implementation Bug #3

YoriKv opened this issue Oct 3, 2018 · 2 comments

Comments

@YoriKv
Copy link

YoriKv commented Oct 3, 2018

superfastblur/SuperfastBlur/GaussianBlur.cs

Line 133 in 1611c1a

val += source[ri++] - dest[li++];

Just a heads up for the author or anyone else trying to use this code, this line should be:

val += source[ri++] - source[li++];

Currently it is source - dest.
@aloker
Copy link

aloker commented Apr 8, 2020

Thanks! The image appeared to be shifted to the right somehow. Now it looks fine.

@bsoglin
Copy link

bsoglin commented Apr 8, 2023

Noticed small aberrations appearing in the blurred image without this change, good catch!

Jabbado added a commit to Jabbado/superfastblur that referenced this issue Jan 14, 2024
@Jabbado
Update GaussianBlur.cs
5bad1a1 
Fixed bug
mdymel#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aloker @YoriKv @bsoglin