Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tw icon to menu and sidebar; optimised search's css #946

Merged
merged 1 commit into from
Feb 13, 2020
Merged

feat: added tw icon to menu and sidebar; optimised search's css #946

merged 1 commit into from
Feb 13, 2020

Conversation

natterstefan
Copy link
Contributor

@natterstefan natterstefan commented Feb 13, 2020

Twitter Button & Header improvements

(...) please try to limit the scope (...)

Hopefully, updating the Header and Search is still in the scope of adding the Twitter Button from your point of view. Let's see. :)

Resolves #945

Twitter Button

Twitter Button in the Header (previous top - new bottom)

image

Twitter and GitHub button in the Sidebar (previous left - new right)

image

Search Updates (previous left - now right)

Due to the new Twitter button in the Header, I had to improve (fix) the css of the Search component as well.

Increased em in the existing Media Query

mediaQueries: {
-	big: '@media screen and (min-width: 40em)'
+   big: '@media screen and (min-width: 48em)',
+   maxBig: '@media screen and (max-width: 47.9em)'
}

This resolves issues on smaller devices (eg. iPhone 5 or iPad):

  • DarkToggle button was not visible, due to the width of the Search input
  • menu is not rendered, but can be opened with a click on the burger button

image

image

image

References

@vercel vercel bot temporarily deployed to Preview February 13, 2020 20:32 Inactive
@vercel
Copy link

vercel bot commented Feb 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mdx/mdx/7xxg95n52
✅ Preview: https://mdx-git-fork-natterstefan-feature-twitter-icon-menu-header.mdx.now.sh

@natterstefan natterstefan changed the title feat: added tw icon to menu and sidebar; optimised search\'s css feat: added tw icon to menu and sidebar; optimised search's css Feb 13, 2020
@natterstefan natterstefan requested a review from johno February 13, 2020 20:37
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨

Awesome, thank you!

@johno johno merged commit b75d9c4 into mdx-js:master Feb 13, 2020
@natterstefan
Copy link
Contributor Author

:) You'r welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add link to MDX twitter account in the header
2 participants