Improve parsing for JSX blocks (including inline) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
johno
commented
Feb 11, 2019
| const openTag = '<[A-Za-z]*[A-Za-z0-9\\-]*' + attribute + '*\\s*\\/?>' | ||
| const closeTag = '<\\/[A-Za-z][A-Za-z0-9\\-]*\\s*>' | ||
| const openTag = '<[A-Za-z]*[A-Za-z0-9\\.\\-]*' + attribute + '*\\s*\\/?>' | ||
| const closeTag = '<\\/[A-Za-z][A-Za-z0-9\\.\\-]*\\s*>' |
There was a problem hiding this comment.
This allows for Component.Foo style components.
johno
commented
Feb 11, 2019
| @@ -7,7 +7,7 @@ const attributeName = '[a-zA-Z_:][a-zA-Z0-9:._-]*' | |||
| const unquoted = '[^"\'=<>`\\u0000-\\u0020]+' | |||
| const singleQuoted = "'[^']*'" | |||
| const doubleQuoted = '"[^"]*"' | |||
| const objectProps = '{{[^}]*}}' | |||
| const jsProps = '{[^\n]*}' | |||
There was a problem hiding this comment.
Accept anything inside props={/* ... */} to handle everything from functions, to string interpolation, to nested objects.
Co-Authored-By: johno <[email protected]>
johno
added a commit
that referenced
this pull request
Feb 18, 2019
* Implement support for Some.Component style JSX blocks * Add failing test for string interpolation * Add failing test for js functions as props * Add failing test for js functions as props with returns * Make value parsing for JSX props more flexible * Don't lint fixtures file * Add nested object props fixture * Add another fixture for randomly placed brackets * Add link shortcut to fixture * Remove object props since it is a subset of js props * Update packages/remark-mdx/test/fixtures/inline-parsing.js Co-Authored-By: johno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX tag parsing was too strict for props, so it caused multiple types of JSX blocks to be missed and then escapes. Ultimately, essentially any syntax and characters can existing in a JSX prop so we just keep waiting for the matching closing curly brace.
This also adds many more complex usages of inline JSX fixtures that are being tested against.