-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to improve wording #2513
Conversation
importing mdx not md Signed-off-by: Dmitry Filippov <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2693 2712 +19
Branches 2 2
=========================================
+ Hits 2693 2712 +19 ☔ View full report in Codecov by Sentry. |
Hi! Why do you think this is a mistake? I think this is intended! |
I think the comment should say |
I kinda get what you're saying but saying "md" there feels a bit more static. Like using marked/remark/markdown-it. |
@wooorm @remcohaszing if you look into the code snippet from |
Yes you can, our packages can do that! Please see what MDX is, particularly this note: https://mdxjs.com/docs/what-is-mdx/#mdx-syntax. |
fixing additional examples in the docs to import mdx not md Signed-off-by: Dmitry Filippov <[email protected]>
@wooorm I'm wrong and you're right. Indeed with the bundler configured it also compiles regular markdown to JS which is also described in Quick Start. Do you think changing the comment would be beneficial to stress the fact that md is also compiled to JS? something like this: |
Signed-off-by: Titus <[email protected]>
thanks :) |
importing mdx not md
Initial checklist
Description of changes
Fixing a typo in the code snipped importing from
mdx
notmd
directly.