Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo of the sample Webpack config in doc #1475

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Fix a typo of the sample Webpack config in doc #1475

merged 1 commit into from
Mar 8, 2021

Conversation

Gowee
Copy link
Contributor

@Gowee Gowee commented Mar 3, 2021

The context says:

...define the following webpack.config.js extension handler for .md and .mdx files...

If you only want the loader for .mdx files you can change the regex to /\.mdx$/.

So I suppose the RegExp in the sample config should have be test: /\.mdx?$/.

@Gowee
Fix typo in the sample config for Webpack
5eab964 
L39 says:

> If you only want the loader for `.mdx` files you can _change_ the regex to `/\.mdx$/`.

So I suppose the RegExp in the sample config should have be `test: /\.mdx?$/`.
@vercel
Copy link

vercel bot commented Mar 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/7Nqgok69ZX3cQGHsaqQ7DMMY5QGg
✅ Preview: https://mdx-git-fork-gowee-patch-1-mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview March 3, 2021 08:07 Inactive
johno
johno approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johno johno merged commit 66bd0c6 into mdx-js:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gowee @johno