Update examples, react
#1415
Merged
Update examples, react
#1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `react`, `react-dom` * Clean Next, Razzle, Vue examples * Update parcel example, parcel plugin, run tests * Prefer `.mdx` extension over `.md` * This does not yet touch CRA * It’s impossible to get Gatsby working in our workspace (they fork MDX but resolve from their dependency on old MDX) * I can’t get webpack 5 working either Related to GH-1292.
wooorm
added
🦋 type/enhancement
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/ga6p75usz [Deployment for 5f5b158 failed] |
wooorm
commented
Dec 24, 2020
| @@ -53,7 +53,7 @@ module.exports = { | |||
| module: { | |||
| rules: [ | |||
| { | |||
| test: /\.mdx?$/, | |||
| test: /\.mdx$/, | |||
There was a problem hiding this comment.
Push our own extension.
Several tools already handle markdown (e.g., parcel), which we shouldn’t overwrite. And MDX is somewhat different, so it’s good to push the different extension
| const MDX = require('@mdx-js/runtime') | ||
| const {MDXProvider} = require('@mdx-js/react') | ||
|
|
||
| const MDXContent = ` | ||
| # Hello, world! | ||
|
|
||
| From <Color bgBlack white bold> MDX! </Color> | ||
| From <Text backgroundColor="black" color="white" bold>MDX!</Text> |
| @@ -1,29 +1,20 @@ | |||
| <template> | |||
There was a problem hiding this comment.
mostly a smaller, MVP, example
| "scripts": { | ||
| "test-api": "jest test", | ||
| "test-coverage": "jest test --coverage", | ||
| "test": "yarn test-coverage" |
There was a problem hiding this comment.
this package had tests, but they were never tested
ChristianMurphy
approved these changes
Dec 24, 2020
ChristianMurphy
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react,react-dom.mdxextension over.mdRelated to GH-1292.