fix edit link #1261
Merged
fix edit link #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/rh6f3gw26 |
|
Any reason why this is marked as WIP? |
johno
approved these changes
Sep 8, 2020
wooorm
pushed a commit
that referenced
this pull request
Dec 17, 2020
* fix edit link * fix another one
wooorm
pushed a commit
that referenced
this pull request
Dec 17, 2020
* fix edit link * fix another one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Edit this page on Githubbutton on this https://mdxjs.com/getting-started page points to https://github.com/mdx-js/mdx/edit/master/docs/getting-started.mdx which returns 404, the right one is https://github.com/mdx-js/mdx/edit/master/docs/getting-started/index.mdx.And here's the code deciding to append
/index.mdxor not:https://github.com/mdx-js/mdx/blob/master/packages/gatsby-theme-mdx/src/components/edit-link.js#L11
It doesn't really eliminate the problem because user can still access
/getting-startedand has a brokeneditlink, but it's no longer a problem if they access/getting-startedpage by clicking the sidebar menu.