Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to @mdx-js/preact #1233

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Aug 24, 2020

mostly the same as mdx react typing https://github.com/mdx-js/mdx/blob/9a33ae598b9f84afa4f95e71f605a08c081e96bb/packages/react/types/index.d.ts
except:

  • disable the disableParentContext property that mdx react has (not sure if it is supported in preact)
  • adding configuration for jsxFactory so TypeScript looks at preact's h function for JSX scripting.

@ChristianMurphy ChristianMurphy added 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2 ☂️ area/types This affects typings 🧑 semver/major This is a change labels Aug 24, 2020
@ChristianMurphy ChristianMurphy requested a review from a team August 24, 2020 16:37
@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/1egw47vdn
✅ Preview: https://mdx-git-types-mdx-preact.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview August 24, 2020 16:37 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2020 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview August 24, 2020 16:43 Inactive
@ChristianMurphy ChristianMurphy requested a review from a team September 18, 2020 21:51
@wooorm
Copy link
Member

wooorm commented Nov 13, 2020

Thoughts on who could help review whether this is good? Can we reach out to the folks that contributed the mdx/preact?

@ChristianMurphy
Copy link
Member Author

Can we reach out to the folks that contributed the mdx/preact?

Sounds like a plan

/cc @ChristopherBiscardi who contributed #955 to mdx preact
/cc @JounQin who contributed #1023 to mdx preact

@ChristopherBiscardi
Copy link
Member

looks fine to me as long as it works with the new build stuff we're implementing (microbundle basically, which it does)

@wooorm wooorm changed the title types: add typescript typings for mdx preact Add types to @mdx-js/preact Nov 19, 2020
@wooorm
Copy link
Member

wooorm commented Nov 19, 2020

Looks good to go, but there are conflicts

@vercel vercel bot temporarily deployed to Preview December 1, 2020 17:59 Inactive
@johno
Copy link
Member

johno commented Dec 1, 2020

Thanks!

@johno johno merged commit 8c922e4 into mdx-js:next Dec 1, 2020
@ChristianMurphy ChristianMurphy deleted the types/mdx-preact branch December 1, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 🧑 semver/major This is a change 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2
Development

Successfully merging this pull request may close these issues.

4 participants