-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to @mdx-js/preact
#1233
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/1egw47vdn |
574a5b9
to
41b4348
Compare
41b4348
to
b80fa37
Compare
Thoughts on who could help review whether this is good? Can we reach out to the folks that contributed the mdx/preact? |
Sounds like a plan /cc @ChristopherBiscardi who contributed #955 to mdx preact |
looks fine to me as long as it works with the new build stuff we're implementing (microbundle basically, which it does) |
@mdx-js/preact
Looks good to go, but there are conflicts |
Thanks! |
mostly the same as mdx react typing https://github.com/mdx-js/mdx/blob/9a33ae598b9f84afa4f95e71f605a08c081e96bb/packages/react/types/index.d.ts
except:
disableParentContext
property that mdx react has (not sure if it is supported in preact)jsxFactory
so TypeScript looks at preact'sh
function for JSX scripting.