Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to benchmark branch. #1205

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

cesutherland
Copy link

Add error handling to hopefully save someone a couple minutes.


I ran the benchmark against v2.0.0-next.7 and the suite failed successfully. Adding error handling revealed an error on html comments <!-- … from remark-mdx. (Removing the comment, the benchmark on v2 clocks in exactly where 1.6 did!)

$ yarn start
yarn run v1.22.4
$ node .
[122:2: Unexpected character `!` (U+0021) before name, expected a character that can start a name, such as a letter, `$`, or `_`] {
  message: 'Unexpected character `!` (U+0021) before name, expected a character that can start a name, such as a letter, `$`, or `_`',
  name: '122:2',
  reason: 'Unexpected character `!` (U+0021) before name, expected a character that can start a name, such as a letter, `$`, or `_`',
  line: 122,
  column: 2,
  location: {
    start: { line: 122, column: 2, offset: 2598, index: 1 },
    end: { line: null, column: null }
  },
  source: 'remark-mdx',
  ruleId: 'unexpected-character',
  fatal: true
}
error Command failed with exit code 1.

@vercel
Copy link

vercel bot commented Aug 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/jxsnz0u2i
✅ Preview: https://mdx-git-fork-humblesoftware-benchmarks.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview August 1, 2020 12:59 Inactive
@vercel vercel bot temporarily deployed to Preview August 1, 2020 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview August 1, 2020 13:07 Inactive
@johno
Copy link
Member

johno commented Aug 1, 2020

Thanks!

@johno johno merged commit ce2bcbd into mdx-js:benchmarks Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants