Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change custom request types to LSP commands #473

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Change custom request types to LSP commands #473

merged 6 commits into from
Sep 8, 2024

Commits on Aug 30, 2024

  1. Change custom request types to LSP commands 

    LSP commands are the intended way to implement custom behaviour.
    @remcohaszing
    remcohaszing committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    535fa9c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Fix a broken test

    @remcohaszing
    remcohaszing committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    7e982e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Refactor commands 

    Commands now use a switch to differentiate between commands. Existing
logic was too clever. The currently existing commands are similar, but
future commands might not be. The new pattern is more flexible.
    @remcohaszing
    remcohaszing committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    07cd18f View commit details
    Browse the repository at this point in the history

  2. Use workspace/applyEdit commands to apply text changes 

    This means clients need to implement less custom logic.
    @remcohaszing
    remcohaszing committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d1e4e81 View commit details
    Browse the repository at this point in the history

  3. Update documentation

    @remcohaszing
    remcohaszing committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cf1da61 View commit details
    Browse the repository at this point in the history

  4. Move language-server dependency vscode-uri to dev dependencies 

    It’s no longer used in production code.
    @remcohaszing
    remcohaszing committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    08da27f View commit details
    Browse the repository at this point in the history