Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incompatible with react/jsx-sort-props rule #490

Merged
merged 3 commits into from
Dec 12, 2023
Merged

fix: incompatible with react/jsx-sort-props rule #490

merged 3 commits into from
Dec 12, 2023

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 10, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

close #488

@JounQin JounQin added the 🐛 type/bug This is a problem label Dec 10, 2023
@JounQin JounQin self-assigned this Dec 10, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4b10add

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
eslint-mdx Patch
eslint-plugin-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 10, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (311bdfa) 100.00% compared to head (4b10add) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##           fix/437      #490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          188       188           
  Branches        32        32           
=========================================
  Hits           188       188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin JounQin marked this pull request as ready for review December 10, 2023 18:27
JounQin
JounQin commented Dec 10, 2023
View reviewed changes
test/fixtures.test.ts
@@ -2,8 +2,9 @@ import path from 'node:path'

import { ESLint } from 'eslint'

const getCli = (lintCodeBlocks = false) =>
const getCli = (lintCodeBlocks = false, fix?: boolean) =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added fix cases in this PR to see whether fix feature is working as expected.

@JounQin JounQin merged commit a3a86d8 into fix/437 Dec 12, 2023
19 checks passed
@JounQin JounQin deleted the fix/488 branch December 12, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm wooorm approved these changes

@remcohaszing remcohaszing Awaiting requested review from remcohaszing

Assignees

@JounQin JounQin

Labels
🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JounQin @codecov-commenter @wooorm @ChristianMurphy