-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for MDX v3 #481
Conversation
Updating dependencies.
Updating dependencies.
|
CI broken, it seems more changes are required, I'll take a look tomorrow. |
@wooorm Any advice about how to migrate like |
@JounQin have you tried |
It won't work because we need the followings: |
@JounQin it will work if See https://www.npmjs.com/package/mdast-util-mdx-expression/v/2.0.0?activeTab=code index.d.ts at around line 120. This is how all the mdast parsers register new content types, using content maps, which can be automatically extended parsers so that |
See also the readmes, e.g.: https://mdxjs.com/packages/remark-mdx/#types |
OK, it seems we need: /// <reference types="remark-mdx" />
import type { Root } from 'mdast' I'll try it this night. (Previously, I'm not aware that referencing |
I'm still seeing this... @ChristianMurphy @wooorm I tried: /// <reference types="remark-mdx" />
import type { Root } from 'mdast' Or /// <reference types="mdast-util-mdx-expression" />
import type { Root } from 'mdast' |
You are missing |
@wooorm There are some |
Correct |
@JounQin Thank you. I've smoke tested this just a bit. Seems to do the trick.
./package.json
for each of the two packages.Configuration
import fromunified-engine
.Thanks in advance for anyone able to have a look at this with more experienced eyes than mine.
close #480