-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for eslint 8 #353
Conversation
@@ -1 +1,5 @@ | |||
<!-- eslint-disable-next-line no-console -- Here's a description about why this configuration is necessary. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@@ -44,6 +44,12 @@ | |||
"yarn-deduplicate": "^3.1.0" | |||
}, | |||
"resolutions": { | |||
"@typescript-eslint/eslint-plugin": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies have not been upgraded in my @1stg/eslint-config
due to eslint-plugin-mdx
.
@@ -63,6 +69,7 @@ | |||
"eslint/lib/linter/linter" | |||
], | |||
"moduleNameMapper": { | |||
"^eslint/use-at-your-own-risk$": "<rootDir>/node_modules/eslint/lib/unsupported-api.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally it should be supported by jest itself.
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 509 515 +6
Branches 108 108
=========================================
+ Hits 509 515 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m 👍 to these changes because I assume you did it correctly and I don’t see anything weird. I personally don’t know enough about ESLints to judge this though!
I've test it on my own project, so let's merge And release. |
@wooorm Ready to release. |
@wooorm Any time to release? |
Thanks for the reminder, released! |
No description provided.