Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n key for delete image functionality #634

Conversation

JohnsonMao
Copy link

@JohnsonMao JohnsonMao commented Nov 17, 2024

While adding support for multiple languages, I noticed that the translation for "Delete image" was not working. Upon investigation, I found that the key for "Delete image" was missing under imageEditor.

Currently, to apply the correct translation, we need to use image.delete:

{
    "image": {
        "delete": "Delete image"
    },
    "imageEditor": {
        "editImage": "Edit image"
    }
}

Expected Update
Move the "Delete image" key under imageEditor for consistency:

{
    "imageEditor": {
        "deleteImage": "Delete image",
        "editImage": "Edit image"
    }
}

As a non-native English speaker, I welcome any suggestions for improvement.

image

@JohnsonMao JohnsonMao force-pushed the fix/i18n-key-for-delete-image-functionality branch from 4d204bd to 0dc9667 Compare November 21, 2024 13:08
@petyosi
Copy link
Contributor

petyosi commented Nov 21, 2024

I will merge that soon, thank you.

@petyosi petyosi merged commit e8baa67 into mdx-editor:main Nov 24, 2024
Copy link

🎉 This PR is included in version 3.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JohnsonMao JohnsonMao deleted the fix/i18n-key-for-delete-image-functionality branch November 24, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants