#14 WIP Add emailToken type and getTokens() #39
Conversation
|
Hey @gracekishino ! I'll take a look! So far it looks like our CI/CD has picked up some errors. Do you mind taking a look at them? |
gracekishino
changed the title
|
@mdwiltfong thanks so much! Just noticed that, was using Boolean instead of boolean. |
|
Noice! Let me give it a review. |
|
This looks good! Although, I need to see some tests 😬 Do you mind adding some to |
|
@mdwiltfong will do! Thanks for the guidance for this! |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 04c863e | server/mockData/mockData.ts | View secret |
| - | Generic High Entropy Secret | 41030c9 | server/mockData/mockData.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
@mdwiltfong still working on this so no need to check it yet! |
|
@mdwiltfong thanks for today! Wondered if you could point me in the direction of how to mock a JWT token? I did a search on the npmjs.com site and got these results but wasn't sure which one (if any) is most appropriate: |
@mdwiltfong I've had a go at adding in the tokens to
server/prisma/index.ts.I wasn't exactly sure what the file was for so asked ChatGPT and added a comment to the top of the file about what I think it's for, please let me know if it's not right and also if the code is OK!