Belgium BBAN check fix #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdomke this was an issue we did notice ourselves. Thanks for having a look! |
mhemeryck
force-pushed
the
be_bban_checksum_edge_case
branch
from
7489d64 to
fa1aa97
Compare
|
Relates to #51 |
The Belgian BBAN check has an issue when the checksum digits are exactly "97". This is because the BBAN calculation is done using the "account number" mod 97; normally, this would result in a checksum digit of "00", but the standard in that case uses "97" instead. Updated the checksum calculation to handle this case, plus updated the related unit test.
Indicate in docs that Belgian BBAN is also checked.
mhemeryck
force-pushed
the
be_bban_checksum_edge_case
branch
from
fa1aa97 to
90f7718
Compare
|
Thank you very much! |
mdomke
added a commit
to Krystofee/schwifty
that referenced
this pull request
Sep 22, 2023
* master: (42 commits) Add missing banks (mdomke#145) chore(python): add Python 3.12 in test matrix (mdomke#149) Update all available bank registries Fetch the new bank registry for Germany Set bic to "" to avoid TypeError for Ukrainian banks chore: Update GitHub workflow actions chore: Update build badge URL Add changelog for 2023.03.0 release Update bank registry for Ukraine Update bank registry for Slovenia Update bank registry for Netherlands Update bank registry for Poland Update bank registry for Germany Update bank registry for Hungary Update bank registry for Belgium Update bank registry for Austria Add norwegian bank registry (mdomke#137) chore: Update generated bank registries chore(bank_registry): added new banks for IT, fixed codes for CY, PT (mdomke#134) Belgium BBAN check fix (mdomke#136) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Belgian BBAN check has an issue when the checksum digits are exactly "97". This is because the BBAN calculation is done using the "account number" mod 97; normally, this would result in a checksum digit of "00", but the standard in that case uses "97" instead.
Updated the checksum calculation to handle this case, plus updated the related unit test.
Relevant links: