Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance update (formatting, automated build, publications, and OpenMDAO updates) #45

Merged
merged 25 commits into from
Mar 3, 2023

Conversation

eytanadler
Copy link
Collaborator

@eytanadler eytanadler commented Feb 19, 2023

Purpose

This PR addresses four maintenance tasks:

  • Updates the code formatting for black version 23
  • Changes the GitHub Actions build to test two versions of the dependencies, the oldest supported versions of all packages and the latest versions. It also tests them regularly, even if no PRs are made, to ensure that dependency version updates don't break OpenConcept.
  • Updates the publications with recent ones and edits the OpenAeroStruct integration citation to be the newly-published journal paper.
  • Makes changes to tests to accommodate newer OpenMDAO versions (gets rid of any cases where the top level model is not a group and catches different error thrown by newer OM versions in one test)

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Maintenance (GitHub Actions)
  • Code style update (formatting, renaming)
  • Documentation update

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler removed the request for review from bbrelje February 19, 2023 16:47
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #45 (7c20b65) into main (ae1d52e) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   80.28%   80.25%   -0.04%     
==========================================
  Files          84       84              
  Lines        8974     8974              
==========================================
- Hits         7205     7202       -3     
- Misses       1769     1772       +3     
Impacted Files Coverage Δ
examples/minimal_integrator.py 60.41% <0.00%> (-2.09%) ⬇️
examples/minimal.py 72.85% <0.00%> (-1.43%) ⬇️
examples/TBM850.py 70.24% <0.00%> (-0.83%) ⬇️
mission/phases.py 99.53% <0.00%> (ø)
mission/mission_groups.py 97.51% <0.00%> (ø)
utilities/visualization.py 7.57% <0.00%> (ø)
utilities/math/integrals.py 91.02% <0.00%> (ø)
utilities/math/derivatives.py 95.06% <0.00%> (ø)
atmospherics/atmospherics_data.py 100.00% <0.00%> (ø)
aerodynamics/openaerostruct/drag_polar.py 92.45% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bernardopacini
bernardopacini previously approved these changes Feb 20, 2023
Copy link
Collaborator

@bernardopacini bernardopacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just out of curiosity, is there a specific motivation for the time / dates of the scheduled runs or are those random?

@eytanadler eytanadler changed the title Maintenance update (formatting, automated build, and publications) Maintenance update (formatting, automated build, publications, and OpenMDAO updates) Mar 2, 2023
@awccopp
Copy link

awccopp commented Mar 2, 2023

Lgtm

Copy link
Collaborator

@bernardopacini bernardopacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we be concerned about the hanging Mac tests?

@eytanadler eytanadler merged commit 573f1eb into mdolab:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants