Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and linting #42

Merged
merged 7 commits into from
Aug 11, 2022
Merged

Formatting and linting #42

merged 7 commits into from
Aug 11, 2022

Conversation

eytanadler
Copy link
Collaborator

@eytanadler eytanadler commented Aug 11, 2022

Purpose

Formatted the openconcept codebase and addressed flake8's complaints. It also renames the docs to doc to be consistent with the other MDO Lab codes. Finally, it removes the docs extensions (in the _exts folder).

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Code style update (formatting, renaming)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner August 11, 2022 14:48
@eytanadler eytanadler marked this pull request as draft August 11, 2022 14:48
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #42 (6ea79bf) into main (1c407d9) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   81.22%   80.96%   -0.26%     
==========================================
  Files          84       84              
  Lines        9127     8967     -160     
==========================================
- Hits         7413     7260     -153     
+ Misses       1714     1707       -7     
Impacted Files Coverage Δ
costs/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
examples/HybridTwin_active_thermal.py 0.00% <0.00%> (-8.20%) ⬇️
costs/costs_commuter.py 0.00% <0.00%> (-7.60%) ⬇️
thermal/ducts.py 90.67% <0.00%> (-0.46%) ⬇️
utilities/math/derivatives.py 95.06% <0.00%> (-0.40%) ⬇️
examples/HybridTwin.py 54.09% <0.00%> (-0.38%) ⬇️
examples/KingAirC90GT.py 79.36% <0.00%> (-0.33%) ⬇️
utilities/math/combine_split_comp.py 87.93% <0.00%> (-0.31%) ⬇️
utilities/math/integrals.py 91.02% <0.00%> (-0.20%) ⬇️
examples/Caravan.py 77.77% <0.00%> (-0.19%) ⬇️
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eytanadler eytanadler marked this pull request as ready for review August 11, 2022 15:42
@eytanadler eytanadler requested review from awccopp and lamkina and removed request for lamkina August 11, 2022 17:24
Copy link

@awccopp awccopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks properly formatted to me.

@eytanadler eytanadler merged commit 5c9eef5 into mdolab:main Aug 11, 2022
@eytanadler eytanadler deleted the formatting branch August 11, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants